This seems broken now?

@marcoow

The slug in the PR description wasn't updated from the previous version (now it is), it should be /c-to-rust-migration/, so the working preview is here:

https://deploy-preview-2865--objective-northcutt-37494c.netlify.app/c-to-rust-migration/

I still need to address Linn's latest comments from Notion though.

I think it looks good!

@marcoow I added the Mailchimp audience "Mainmatter C to Rust", so please use that for the sign-up form. I set it up as a duplicate based on the Rust audience, feel free to make any changes you see fit directly in Mailchimp.

@avollrath @mainmatterlinnbp we should think about where and how this page is linked from the rest of mainmatter.com. If you get to this and navigate away, there should be a way to find it again?

@avollrath @marcoow I pushed a change with my suggestions for improved copy, please have a look!

Thanks @JonasKruckenberg. Looks good to me overall, I'll make the copy a bit smoother next week.

@avollrath can you finish the above task for you?

the crawler should go green once the GH repo is open-sourced and we remove the custom mdbook theme

@avollrath do you know why https://deploy-preview-2865--objective-northcutt-37494c.netlify.app/c-to-rust-migration/ still works (but the page it renders is outdated/broken) when it should be https://deploy-preview-2865--objective-northcutt-37494c.netlify.app/c-to-rust-migration-book/ (see https://github.com/mainmatter/mainmatter.com/pull/2865/changes#diff-3102876604bb31137f347378af10d53f6a5154ea54b03f8662eae94686df7881R5)

@avollrath do you know why https://deploy-preview-2865--objective-northcutt-37494c.netlify.app/c-to-rust-migration/ still works (but the page it renders is outdated/broken) when it should be https://deploy-preview-2865--objective-northcutt-37494c.netlify.app/c-to-rust-migration-book/ (see https://github.com/mainmatter/mainmatter.com/pull/2865/changes#diff-3102876604bb31137f347378af10d53f6a5154ea54b03f8662eae94686df7881R5)

Could it be because the repo build writes into dist without cleaning old generated pages? Then the old slug could still exist after the permalink changed.

I’m not sure whether this is preview-specific or also possible for production without seeing the Netlify logs. Has this come up before with other permalink changes?

This doesn't look polished yet tbh:

@marcoow Better as a flyout menu?

ok, redeploy with emptied cache fixed it

I guess having it inline works as well but the menu shouldn't change it's width when the learning materials are expanded and we should animate the arrows as we do elsewhere

@marcoow If we want to keep it inline and with the same width, it comes with the tradeoff that that space needs to be reserved beforehand in the main menu -> so that's wider by default now. The caret icon ^ behaves the same as in the main menu (next to "More"), just flipping up and down.
I added subtle animation for the nested items appearing and the menu vertically expanding, so it feels a bit smoother.

What do you think about this version?

I think this is better – stuff jumping around just isn't great. Should we not animate the caret as well?

@marcoow

100%, no jumping is much better.

I've now done those adjustments:

• Added animations for the carets, nested menu items, and a quick overall menu opening animation (Had to use js for the nested menu animation because Safari does not reliably animate it smoothly with css only (animation is still just css transitions though))
• Reduced hero toc font size so it fits on a single line
• Added the books as a background for the mobile CTA block

I also made a those changes earlier:

• Increased Jonas' author image
• Switched the arrow position in the "Contact us" row
• Moved the "by Mainmatter" label closer to the title

I think that covers everything I was pinged for (Jonas updated html and pdf with the latest version today)